![]() You should avoid using "i" during the hash computation and store "it" instead.Oh, and the hash algorithm I used is optimized for speed, so it has quite a bit of collisions. What do you mean by hash of list ?(did you mean list of hashes?).Same for hash of hash. Why not using a hash of hash (instead of a hash of list) to store the hash keys, would be a lot easier to detect duplicates (no sort, no loop for the duplicate detection).Output an info message to all successful checks.Error messages should be more explicit, for example "Favivon not found in ZIM file" should be "Favivon not found in ZIM file, "/-/favicon" must exist.".It can be switched on by the -progress flag. The progress bar is now switched off by default. Remove progress bar "#", or if you really want to see a progression print a new line each X %.Strange "unknown mime type code 65535" error code on the output.argument parsing seems to be good, but way to store the result is not efficient use a bit array and constants to store the list of checks to do.ĭo we need this? I mean, the current system is easier to understand.methods name should be for example getLinks() instead of get_links().Same for variable names, "arr" is really a bad name for an array.ĭone, please mention if you find anything else. methods names are not well named ("get_links2" is unclear).Zimcheck.cpp was split into 3 different files. zimcheck.cpp is too long, should be split.methodsare too long, code should be factorized.This notion exists only in code comments, and even there, the names of the tests are given along with. should be abandoned everywhere (code&output). Indentation is good, but lack of spaces in the code, in particular around the operators.Multiple small typography issue (for example, never a space before a comma).Explanation are always welcome, but usage() should be short. Launch without argument should print the usage().Error messages in case of bad arguments are unclear (what does "Unknown option `115'" mean?)įixed- BTW, 115 was the ASCII code of the bad argument.Non perfect command line error handling.Try it out for yourself: all the instructions are shown in the Github page. You can then play with Kiwix on your personal machine or even set up your router to make Kiwix available to everyone connected to your local area network. To make it “easier” to set up a Kiwix Server, I have a Dockerfile that creates a Linux virtual machine, installs the Kiwix software, installs your chosen ZIM files, and starts up the server for you. Setting up a Kiwix Server Docker container This could all change, however, as development progresses. Also, it only runs on Linux, which means one must use virtualization in order to deploy or experiment with it on a non-Linux machine.įor people wanting to write custom applications around Kiwix Server, the API to interact with it programatically are also pretty limited. add, delete, update them) as in the desktop app. It is not as easy to manage ZIM files (e.g. There are some downsides to using Kiwix Server, however. Using this approach, one could run Kiwix on a shared server and allow many users to connect to it on their own computers through a local area network. Instead of using a dedicated desktop app to view ZIMs, one runs this server and simply connects to it using their favorite web browser. Kiwix Serverįor users interested in using Kiwix on a desktop, another solution is to use “kiwix-serve” or Kiwix Server, which is a Linux program that runs a server for ZIM files. However, the latest release of the desktop app is version 0.9 which was released in 2014 and does not appear to be under active development (the mobile apps do appear to be under active development, however). There also exist ports for iOS and Android. The desktop version of Kiwix can be downloaded for Windows, macOS, and Linux and basically serves as a browser for viewing ZIM files. This is possible through the availability of ZIM files that are essentially compressed versions of these websites at a moment in time (visit this link to see the kinds of content you can download). Kiwix is a software project that lets you view several popular websites like Wikipedia, TED, and StackOverflow without having to connect to the internet. Host a local version of Wikipedia and other sites for you and your friends and family What is Kiwix? What are ZIM files? ![]()
0 Comments
Leave a Reply. |
Details
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |